Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken tests with SimpleCov 0.16+ #36

Closed
infertux opened this issue Mar 21, 2018 · 3 comments
Closed

Broken tests with SimpleCov 0.16+ #36

infertux opened this issue Mar 21, 2018 · 3 comments
Labels
need feedback

Comments

@infertux
Copy link
Owner

The build is failing with SimpleCov 0.16+. The coverage is now empty when using SimpleCov::ResultMerger.results. I couldn't figure out why at first glance but it must be due to a change in this diff.

This seems to only affect feature tests and normal usage of Bashcov is working for me with SimpleCov 0.16.1.
@infertux infertux reopened this Mar 27, 2018
@tomeon
Copy link
Collaborator

tomeon commented Mar 28, 2018 •
edited
Loading

@infertux -- I'll take a crack at solving this in the next several days.

@tomeon tomeon mentioned this issue Apr 11, 2018
Merged
@tomeon
Copy link
Collaborator

tomeon commented Apr 11, 2018

@infertux -- I found the bug in SimpleCov, and I've opened a PR to correct it: simplecov-ruby/simplecov#674.

@infertux
Copy link
Owner Author

Blocked until simplecov-ruby/simplecov#674 gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
need feedback
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@infertux @tomeon