Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Discovery with Support for New Proposed Discovery Method #267

Closed
dshanske opened this issue Jun 15, 2024 · 2 comments
Closed

Update Discovery with Support for New Proposed Discovery Method #267

dshanske opened this issue Jun 15, 2024 · 2 comments

Comments

@dshanske
Copy link
Member

@janboddez
Copy link
Contributor

janboddez commented Jun 25, 2024

Ha, this must be why I can't log in to the IndieWeb wiki. Right?

Looks like Indielogin.com has already switched to JSON client metadata, and the plugin isn't yet compatible. https://github.com/aaronpk/indielogin.com/blob/35c8aa0ae627517d9c9a9578b901740736ded428/app/Controller.php#L18

Edit: just seeing the PR now. I'll try it when I can. Aaron's also right, the error handling can be improved. E.g., there seem to be some checks in the code (if ( ! $input ) ... and the like), but they may be ineffective. Might be able to help out there, I'll see what I can do.

@dshanske
Copy link
Member Author

dshanske commented Jul 7, 2024

Merged via #268

@dshanske dshanske closed this as completed Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants