Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace CRA with Vite #69

Closed
wants to merge 0 commits into from
Closed

Conversation

AjobK
Copy link
Member

@AjobK AjobK commented Aug 27, 2024

Problem

The compilation process for CRA is long and official support is also being cut off.

Solution

Moving to Vite, which is significantly faster!

vite.config.ts Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster changed the title Replacing CRA with Vite Replace CRA with Vite Aug 27, 2024
index.html Outdated Show resolved Hide resolved
@tomasr8 tomasr8 linked an issue Aug 27, 2024 that may be closed by this pull request
.eslintrc.json Outdated Show resolved Hide resolved
.eslintrc.json Outdated Show resolved Hide resolved
@AjobK AjobK force-pushed the transition-to-vite branch from 37a879d to 21fafdd Compare August 28, 2024 13:00
@tomasr8
Copy link
Member

tomasr8 commented Sep 2, 2024

Tried to do a test deploy and the build fails for some reason:
https://paas.cern.ch/k8s/ns/indico-checkin-test/builds/indico-checkin-pwa-2-17/logs
Will have to dig into why

@AjobK AjobK closed this Sep 9, 2024
@AjobK AjobK force-pushed the transition-to-vite branch from fe2d1b2 to 8449a35 Compare September 9, 2024 12:31
@tomasr8 tomasr8 reopened this Sep 9, 2024
@AjobK AjobK closed this Sep 10, 2024
@AjobK AjobK force-pushed the transition-to-vite branch from 66886bb to 5e3d4cc Compare September 10, 2024 09:37
@AjobK AjobK reopened this Sep 12, 2024
@AjobK
Copy link
Member Author

AjobK commented Sep 12, 2024

Not sure why but the PR seems to close every time I rebase (while testing the new service worker)

Copy link

📝 Lighthouse report

Copy link

📝 Lighthouse report

@AjobK AjobK marked this pull request as draft September 12, 2024 08:20
@AjobK AjobK closed this Sep 13, 2024
@AjobK AjobK force-pushed the transition-to-vite branch from 9bf9cb4 to 5e3d4cc Compare September 13, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate alternatives for CRA
4 participants