Fix issue #58 and issue #42: crashes on Windows 11 24H2 and wrong results on processes with spaces in name #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…windows systems)
MikeMcC399
reviewed
Dec 12, 2024
Co-authored-by: Mike McCready <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves issue #58 : On windows systems ps-tree uses WMIC to get the list of child processes. WMIC is deprecated since 2016. This PR replaces WMIC with powershell (as recommended by Microsoft),
I encountered this problem, when using the start-server-and-run package (see bahmutov/start-server-and-test#384).
Solves issue #42 - ps-treee returns wrong results when process name contains spaces (primarily on windows systems). Issue is caused by splitting a row into columns on spaces. Fixed by getting the column widths, when extracting the headers (all columns have fixed width).