-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI #26
Improve CI #26
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simonepri these improvements make sense. 👍
Lets see if all the tests pass. |
Interesting, some tests on x86 versions fails. |
Maybe we can use something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please make CI green with this PR before we could be able to merge it.
Thank you very much!
The test suite is now correct and tests pass. I've updated the changes in the first comment. Should I split all the changes in separate PRs or is okay to marge this single big PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, You did a great job!
Thanks for the improvements and I'd like to suggest you split it into multiple PRs instead of a single big one.
Changes
cc @nelsonic @indexzero @zixia