Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #26

Closed
wants to merge 28 commits into from
Closed

Improve CI #26

wants to merge 28 commits into from

Conversation

simonepri
Copy link
Collaborator

@simonepri simonepri commented Mar 14, 2018

Changes

  • Refactor for test making them deterministic
  • Update Appveyor CI configs
  • Update Travis CI configs
  • Automatically send coverage report to codeclimate if the tests passes on the CI

cc @nelsonic @indexzero @zixia

Copy link
Collaborator

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonepri these improvements make sense. 👍

@simonepri
Copy link
Collaborator Author

Lets see if all the tests pass.

@simonepri
Copy link
Collaborator Author

Interesting, some tests on x86 versions fails.
Maybe there's some problem with the tests?

@simonepri
Copy link
Collaborator Author

simonepri commented Mar 14, 2018

@simonepri
Copy link
Collaborator Author

Maybe we can use something like
parent.stdout.on('data', () => {});
instead of the timeout.

Copy link
Contributor

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but please make CI green with this PR before we could be able to merge it.

Thank you very much!

@simonepri simonepri changed the title Improve CI Improve CI [WIP] Mar 15, 2018
@simonepri
Copy link
Collaborator Author

simonepri commented Mar 15, 2018

The test suite is now correct and tests pass.

I've updated the changes in the first comment.

Should I split all the changes in separate PRs or is okay to marge this single big PR?
In the second case we need to squash the commits.

cc @nelsonic @indexzero @zixia

@simonepri simonepri changed the title Improve CI [WIP] Improve CI Mar 15, 2018
@simonepri simonepri mentioned this pull request Mar 15, 2018
Copy link
Contributor

@huan huan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, You did a great job!

Thanks for the improvements and I'd like to suggest you split it into multiple PRs instead of a single big one.

This was referenced Mar 16, 2018
@simonepri
Copy link
Collaborator Author

Closing this in favour of:
#27 #28 #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants