make old binary a hidden file on windows since it can't be easily deleted #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the slow response. This looks fine. I'd rather use the native win32 API call instead of a command-line call, but that's a bit more involved. |
|
No worries on the response time ;) I agree that a win32 call would be better, and it turns out it really isn't that much more complicated. However it does seem to require adding a file to contain a function stub for non-Windows systems. |
|
Better late than never =) Sorry for the long delays on getting this merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A quick attempt to fix #1. Hiding the file seems a good enough solution compared to the hoops you have to jump through to actually delete it.