-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Grand Mean scaling / Normalisation - Voxelwise vs. imagewise vs. 1 single scalefactor #413
Comments
Adding terms seems reasonable, since it is probably a lot of work to rename and alter one (which might cause backward compatibility issues, given that it this is surely already in use). |
Thank you @nicholst and @afni-rickr for your comments! To summarise, I can see two options:
As @afni-rickr was pointing out, option 1 would break backward compatibility and therefore require releasing a new major version of NIDM-Results. Nevertheless, to me this first option is a better match as it prevents having grand mean / voxel-wise and image-wise scaling being specified simultaneously. It is also a simpler model to query (search for one attribute instead of three). So, I would be in favour of option 1 but my suggestion would be to continue checking the compatibility of NIDM-Results on more AFNI examples before we release a new major version of NIDM-Results. @nicholst, @afni-rickr, all: Does this seem reasonable? As a side note, @nicholst: do you have an example of use case that uses 'Voxel-wise ANCOVA'? Would it make sense to consider that this case is already modelled by the design matrix entity? |
@cmaumet, Do not you mean that Option 1 is preferable (one attribute instead of three)? |
Yes, thanks @tiborauer!! (I've updated the text above) |
I guess I'm partial to not breaking NIDM-Results, but agree Option 1 is more elegant than 2. I would like to hear from the people that it potentially actually affect... e.g. would this require changes to Neurovault's NIDM reader @chrisfilo ? And @gllmflndn do you have a view? @cmaumet If we do move from a binary |
@afni-rickr - Fair points. I've updated my post above to point out that (my) option 4 is also common. (Option 1 is indeed common for 2nd level models as you note). |
Currently we have exactly one term for data scaling: nidm:'grand Mean Scaling' with definition
There are are at least 5 ways that intensity normalisation can be done:
The original definition nidm:'grand Mean Scaling' was set as binary since SPM and FSL only use 1 & 2. We are now expanding it since AFNI routinely uses 4. (Option 5 is common for PET but, notably, also corresponds to "Global Signal Regression" used in resting state fMRI analyses.)
The notion of "scaling" is encompassed by options 2-4 above, and so we could leave nidm:'grand Mean Scaling' intact and add new terms to cover these all these options.
The text was updated successfully, but these errors were encountered: