DEX-00 comments #137
Open
DEX-00 comments #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the overview as we agreed that the export is not always for a collector
but rather from the network in general
there was misalignment between the fixed paragraph, which state that all must export data, and the following which say the may. I think that MAY is the right option, so it was fixed.
data may not be sent out of the device, hence the text should reflect that
|
One more question to consider is regarding the checksum complement bit - whether it MUST be zero and whether nodes along the way should check it. I believe that it should just be ignored is stated in the draft already, but need to decide on the requirement from the encapsulator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edits to the draft, including updates regarding the role of each type of node in the network, generalization of exporting the data from the network, and further discussions on performance, security and hop limit