Theme of the app dark and light mode added #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
littleironical
requested changes
Dec 31, 2020
There was a problem hiding this comment.
A few changes needed to be done before I approve this PR:
- Keep the
debugShowCheckedModeBannerto true in main.dart, - Change the variable name from
lightDarktoisLightThemein theme.dart for better understanding, - Change the primary color from
bluetowhite, and - You are creating
Rowinsidetitleand then addingSwitch
Row(
mainAxisAlignment: MainAxisAlignment.spaceBetween,
children: [
Text('Dashboard'),
Switch(
value: _themeChanger.lightDark,
onChanged: (lightDark) {
if (lightDark)
_themeChanger.setTheme(ThemeData.light());
else
_themeChanger.setTheme(ThemeData.dark());
}
)
],
),
You can add Switch inside actions property instead, like this:
actions: [
Switch(
value: _themeChanger.lightDark,
onChanged: (lightDark) {
if (lightDark)
_themeChanger.setTheme(ThemeData.light());
else
_themeChanger.setTheme(ThemeData.dark());
}
),
SizedBox(width: 8.0),
GestureDetector(
onTap: () {
Navigator.push(context, SlideLeftRoute(page: Lessons()));
},
child: CircleAvatar(
backgroundColor: Colors.white70,
backgroundImage: NetworkImage(
'https://i.pinimg.com/originals/da/51/c2/da51c26fe3398b0f8314fee17a98e0e7.jpg',
),
),
),
SizedBox(width: 10.0),
],
),
|
|
Open
littleironical
approved these changes
Dec 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the change?
use of the provider
Related issue?
*issue #4
Screenshots: