Quality Check

[theofidry]

• Scrutinizer
• SensioLabs Insight
• Code quality
  • avoid using $this->client->send and so when can use sendAndDecode (check UserController)
  • $this->sendAndDecode($this->createRequest()) => $this->sendAndDecode()
  • no useless try/catch
  • wrong references
• PHPDoc
• Code coverage
• Tests
  • failed form are refilled
• Providers
  • jobProvider: use jobManager ou chance of null because the manager is called anyway
  • mandateProvider: use mandateManager or chance of null because manager is called anyway
• EventListener
  • no useless return value (JobManagerListener)
• Services name check
  • api.event_listener or event_listener? api.entity_manager or entity_manager? etc...
• Form names (::getName)
• Non null values for the end of mandates (check fixtures)
• composer.lock
• Postman
• Views
  • row show link
• optomize { 'id': mandate['@id']|uriId } calls