Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IronGitHub with VS 2010 and .NET 4.0 #10

Open
geronimoooooooo opened this issue Sep 18, 2013 · 5 comments
Open

IronGitHub with VS 2010 and .NET 4.0 #10

geronimoooooooo opened this issue Sep 18, 2013 · 5 comments

Comments

@geronimoooooooo
Copy link

I just saw your library for accessing GitHub API 3.0 and it looks really nice. The problem is that I have a project that is developed in .NET 4.0 and VS 2010.
But I could only find a library IronGitHub.dll for net 45.

Could you please compile IronGitHub also to .NET 4.0? That would be awesome! Unfortunately I can not change my project to .NET 4.5.

@johnduhart
Copy link
Contributor

Right now the code is written using async/await so we would need to use some sort of shim for 4.0.

@timerickson
Copy link
Member

I don't know how we would "shim" async/await. I think it would need to be rewritten with the traditional AsyncOperation pattern. But we might not have to. Any volunteers to try this? It would only get us down to 4.0. Is that enough?

@JakeGinnivan
Copy link

.net 4.5 is not needed to use async/await, it is a compiler feature. You just need to use the Microsoft.Bcl.Async NuGet package.

Then just make sure it is a framework specific dependency.

@JakeGinnivan
Copy link

So I spiked this. there are 2 options (which I can see)

  1. Use Microsoft.Bcl.Async. It is easy, but means that .net 4.5 gets another dependency (because we need the binding redirect magic those packages give us because IronGitHub is compiled against types which comes from NuGet, but those types are available in .net 4.5 natively). The extra dependency thing kinda blows.
  2. Build twice, once for .net 4.0 which uses the Microsoft.Bcl.Async and the second which doesn't. It just requires some tweaking to the .csproj file to conditionally import it.

PR for option 2 will be up in a minute.

@timerickson
Copy link
Member

Gonna check this out - like the direction...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants