Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reference documentation policy #32

Merged
merged 5 commits into from
Jun 18, 2024

Conversation

DarikshaAnsari
Copy link
Contributor

@DarikshaAnsari DarikshaAnsari commented Jun 18, 2024

Fixes #28

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! IMO we don't need to refer to the docs setup used by the Python in-toto implementation, as It's very Python-specific. But referring to the contents makes sense.

@DarikshaAnsari DarikshaAnsari requested a review from lukpueh June 18, 2024 07:45
@lukpueh
Copy link
Member

lukpueh commented Jun 18, 2024

I think there was a misunderstanding. I specifically suggested to not include Python-specific instructions. If you remove the last commit, we can merge this. :)

@DarikshaAnsari
Copy link
Contributor Author

DarikshaAnsari commented Jun 18, 2024

The previous commit is for the issue #755, these both issue are same so i thought to resolve these in one PR.

@lukpueh
Copy link
Member

lukpueh commented Jun 18, 2024

Okay. Did you see my comments in #755? I transferred the issue to in-toto/in-toto and suggested to add Python in-toto docs guidelines to the Python in-toto repo. A PR against https://github.com/in-toto/in-toto/blob/develop/doc/source/CONTRIBUTING.md with the contents from your last commit here would be appreciated.

@DarikshaAnsari
Copy link
Contributor Author

Okay I got your point now i will revert this last commit then.

Copy link
Member

@lukpueh lukpueh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukpueh lukpueh merged commit 69d51d1 into in-toto:main Jun 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Develop a reference doc contribution policy
2 participants