Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The protobuf field type for annotations in the ResourceDescriptor should be Struct #262

Closed
marcelamelara opened this issue Jul 5, 2023 · 0 comments · Fixed by #263
Closed
Assignees

Comments

@marcelamelara
Copy link
Contributor

Prior to #251, the annotations field in the ResourceDescriptor was of type map[string]Struct. We updated it to map[string]Value to allow mapping of arbitrary values. However, we are now essentially re-implementing the structure of the Struct protobuf type. Using Struct has the advantage of Value handling from the protobuf library, rather than having to do so explicitly in our language bindings.

Since the Struct protobuf type corresponds to the intended map[string]Value type for annotations in the spec, we should update the ResourceDescriptor proto to define the annotations field as a Struct, and highlight that this still meets the spec.

Originally posted by @adityasaky in #227 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant