You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prior to #251, the annotations field in the ResourceDescriptor was of type map[string]Struct. We updated it to map[string]Value to allow mapping of arbitrary values. However, we are now essentially re-implementing the structure of the Struct protobuf type. Using Struct has the advantage of Value handling from the protobuf library, rather than having to do so explicitly in our language bindings.
Since the Struct protobuf type corresponds to the intended map[string]Value type for annotations in the spec, we should update the ResourceDescriptor proto to define the annotations field as a Struct, and highlight that this still meets the spec.
Prior to #251, the
annotations
field in the ResourceDescriptor was of typemap[string]Struct
. We updated it tomap[string]Value
to allow mapping of arbitrary values. However, we are now essentially re-implementing the structure of theStruct
protobuf type. UsingStruct
has the advantage ofValue
handling from the protobuf library, rather than having to do so explicitly in our language bindings.Since the
Struct
protobuf type corresponds to the intendedmap[string]Value
type forannotations
in the spec, we should update the ResourceDescriptor proto to define theannotations
field as aStruct
, and highlight that this still meets the spec.Originally posted by @adityasaky in #227 (comment)
The text was updated successfully, but these errors were encountered: