Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 1.4.2.post1 #209

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Release 1.4.2.post1 #209

wants to merge 4 commits into from

Conversation

schuenke
Copy link
Collaborator

@schuenke schuenke commented Nov 26, 2024

Would be great if we could get this merged / released very soon. I have to give a presentation on Thursday and it would be nice to have the latest fixes released 😄

@schuenke
Copy link
Collaborator Author

I prepared the release draft here:
https://github.com/imr-framework/pypulseq/releases

@schuenke
Copy link
Collaborator Author

schuenke commented Nov 26, 2024

Note sure why GitHub isn't showing the diff of sequence.py correctly. The only change is that I added [:3] in this line:

major, minor, revision = __version__.split('.')[:3]

This works for all version with format major.minor.revision and major.minor.revision.post_release

@btasdelen
Copy link
Collaborator

@schuenke I suggest we fix #208 before we release. It is trivial, I am fixing it right now.

Copy link
Collaborator

@btasdelen btasdelen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the conflict in sequence.py is resolved, looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants