New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc of toolbar needs update #771

Open

ngocdaothanh opened this issue Aug 29, 2020 · 0 comments

ngocdaothanh commented Aug 29, 2020 •

edited

Loading

Currently, the doc in https://github.com/impress/impress.js/blob/master/src/plugins/toolbar/toolbar.js says:

html : "<button>Click</button>", // The html to add.

But the code uses element, not html:

group.appendChild( e.detail.element );

Also, the event impress:toolbar:added is not fired.

See also:
https://github.com/impress/impress.js/blob/master/src/plugins/navigation-ui/navigation-ui.js

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment