Fix: add missing form builder registrar dependencies for WP 6.4 compatibility

[jonwaldstein]

Description

In WP 6.4, some blocks were breaking. This was due to a missing lodash function that should have been loaded by WordPress deps. It turns out we were not defining the dependencies for the form builder registrar script. This PR adds the deps during enqueue.

As a side note, Gutenberg has been moving away from lodash in their packages.

Related:

• Lodash: Refactor away from _.noop()

Affects

WP 6.4 compatability

Visuals

N/A

Testing Instructions

Make sure block are working as expected on latest version of WP and 6.4

Pre-review Checklist

• Acceptance criteria satisfied and marked in related issue
• Relevant @unreleased tags included in DocBlocks
• Includes unit tests
• Reviewed by the designer (if follows a design)
• Self Review of code and UX completed

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1205710544312532

[JasonTheAdams]

Thanks! @jonwaldstein! Are we using Lodash anywhere else?

[jonwaldstein]

Thanks! @jonwaldstein! Are we using Lodash anywhere else?

Yes we are, for debouncing and some other utility things. It's not a problem that we're using it as it's still available as a WP dependency.

[JasonTheAdams]

it's still available as a WP dependency.

But... then why isn't noop working? I'm confused.

[jonwaldstein]

@JasonTheAdams

See PR description

It turns out we were not defining the dependencies for the form builder registrar script.

lodash was not being defined as a dependency for the form builder registrars script (only the form builder app script).

[JasonTheAdams]

Then why are we defining the noop function ourselves instead of using the import?

[jonwaldstein]

Then why are we defining the noop function ourselves instead of using the import?

That's what I initially did and then the dependency part. I decided to leave it though because all the import does is return an empty function and I don't want to rely on lodash to supply that.

[JasonTheAdams]

@jonwaldstein I get your point, but I'd prefer to continue using the documented, shared function, as simple as it is. So either we should have our own, shared noop function that's documented (why would someone even use this!?) or use Lodash. To reduce the scope of this PR, I'm inclined to use the Lodash function.

[jonwaldstein]

@JasonTheAdams when lodash removes noop from their library because they realize its stupid, i'm going to hold you to this f2a9177

[JasonTheAdams]

Deal! 😁

[rickalday]

Passed manual QA tests.