-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid flow imports in no-cycle rule #1231
Conversation
Please don’t close and reopen to kick CI; maintainers can rerun failed builds if needed. |
Already fixed in #1218. |
@vikr01 your PR has fewer code changes, and has appveyor tests failing; this one has decreased coverage, but tests are passing. Can you update yours to include all the test cases here, and see about getting everything green? |
The only new things this PR seems to add are ExportMap.js#L396 and no-cycle.js#L53/54, which are only used by Everything else added, including the tests, were copied from #1218. |
@claramunt since #1218 is merged, I've rebased this - the only changes left have no test coverage. Could you add some? |
Sorry for the delay, didn't see the thread. I'm closing this PR since it seems fixed in other merged PR |
Avoid flow imports in no-cycle rule
Currently no-cycle rule is not working with babel parser, errors are being skipped due to
fixes #1166