import/order throws error in every order

[vtaits]

Input:

/* eslint-disable @typescript-eslint/no-explicit-any */

import {
  Form,
} from 'react-final-form';
import type {
  FormProps as FinalFormProps,
} from 'react-final-form';
import {
  useMemo,
  useCallback,
} from 'react';
import type {
  ReactElement,
  ReactNode,
} from 'react';
import {
  serialize as formSchemaSerialize,
  parse as formSchemaParse,
  mapFieldErrors as formSchemaMapFieldErrors,
} from '@vtaits/form-schema';
import type {
  GetFieldSchema,
} from '@vtaits/form-schema';

Result:

   9:1  error  `react` import should occur before import of `react-final-form`                import/order
  17:1  error  `@vtaits/form-schema` import should occur before import of `react-final-form`  import/order

Trying to fix:

/* eslint-disable @typescript-eslint/no-explicit-any */

import {
  useMemo,
  useCallback,
} from 'react';
import type {
  ReactElement,
  ReactNode,
} from 'react';
import {
  serialize as formSchemaSerialize,
  parse as formSchemaParse,
  mapFieldErrors as formSchemaMapFieldErrors,
} from '@vtaits/form-schema';
import type {
  GetFieldSchema,
} from '@vtaits/form-schema';
import {
  Form,
} from 'react-final-form';
import type {
  FormProps as FinalFormProps,
} from 'react-final-form';

Result:

  11:1  error  `@vtaits/form-schema` import should occur before import of `react`  import/order
  19:1  error  `react-final-form` import should occur before import of `react`     import/order

2nd try:

/* eslint-disable @typescript-eslint/no-explicit-any */

import {
  serialize as formSchemaSerialize,
  parse as formSchemaParse,
  mapFieldErrors as formSchemaMapFieldErrors,
} from '@vtaits/form-schema';
import type {
  GetFieldSchema,
} from '@vtaits/form-schema';
import {
  Form,
} from 'react-final-form';
import type {
  FormProps as FinalFormProps,
} from 'react-final-form';
import {
  useMemo,
  useCallback,
} from 'react';
import type {
  ReactElement,
  ReactNode,
} from 'react';

Result:

  11:1  error  `react-final-form` import should occur before import of `@vtaits/form-schema`  import/order
  17:1  error  `react` import should occur before import of `@vtaits/form-schema`             import/order

I don't know internal magic, maybe reason of bug is typescript or monorepo. You can test it locally:

Repo:

https://github.com/vtaits/form-schema

File:

https://github.com/vtaits/form-schema/blob/master/packages/react-final-form-schema/src/core/Form.tsx

[ljharb]

Seems like a pretty bad bug around import type. Presumably if you moved them all to import it'd pass?

[netcoding87]

I do have the same issue after updating from 2.22.1 to 2.23.2

import type { ReactElement, ReactNode } from 'react'
import { Children, cloneElement, isValidElement } from 'react'

1:1  warning  There should be at least one empty line between import groups  import/order
2:1  warning  `react` import should occur before import of `react`           import/order

[paztis]

Try to invert the order.
All Import type may be after all classic import

[olee]

This is indeed a very bad regression causing a whole lot of errors in our codebase right now as well.
I think that merging #2087 sounds like a good solution.

[vtaits]

Seems like a pretty bad bug around import type. Presumably if you moved them all to import it'd pass?

Yes, it passed without import type.

[geraintwhite]

This is indeed a very bad regression causing a whole lot of errors in our codebase right now as well.
I think that merging #2087 sounds like a good solution.

I've marked the PR as ready for review with all checks now passing. It was draft before as I wasn't sure the approach was correct.