Allow to require from internal project file with import/no-extraneous-dependencies

[piranna]

When importing or requireing an internal file instead of the raw project export, import/no-extraneous-dependencies fails. This is a valid use case, so for example requires to @apollo/client/link/error should be successful if the @apollo/client package is included in package.json file, but right now it's failing since it checks for the full string.

[ljharb]

May be related to #2065 (cc @paztis)

[piranna]

Seems related, yes.

[paztis]

As I explain in the defect #2072, we're recursively searching for the 1st package.json in the @apollo/client/link/error path.
Here we found it in @appolo/client folder
It means a dependency to @appolo/client need to be added.
What exactly is the error you have ? and what is the resolver you use ?

[piranna]

The error I have is that's asking to install a package that its name is the full @apollo/client/link/error, instead of just only @apollo/client. I'm using the default resolver used by Node.js v16.

[paztis]

Is there any package.json under the folder node_modules/@apollo/client/link/error ?

[piranna]

Is there any package.json under the folder node_modules/@apollo/client/link/error ?

Surprissingly yes, I would bet it was not there before:

{
  "name": "@apollo/client/link/error",
  "main": "error.cjs.js",
  "module": "index.js",
  "types": "index.d.ts",
  "sideEffects": false
}

It doesn't make any sense, I've reviewed other folders in the installed @apollo/client package and there's other package.json files, I don't understand what does they do there...

[piranna]

You have Apollo client code at https://github.com/apollographql/apollo-client, and link error at https://github.com/apollographql/apollo-client/tree/main/src/link/error.

[paztis]

Try a fresh install then verify the folder.

[paztis]

solution I propose in #2072 might resolve your problem. It's will be a little less strict on the imports but might be enough for these cases

[gabrielrtakeda]

I think that my problem is related to this...

I'm getting the linting error:

Where I'm importing like:

In my node_modules I have:

And have preact in package.json dependencies:

Is this actually, the expected behavior?
I start to get this linting error after v2.23.0

[paztis]

Ok understood. Preact/hook is a real package with a package.json.
But this package is. Only available under master preact one.

I think one fix can solve it and all other defects.
The module resolution returns us 'preact/hooks'
We can validate it we've exactly this on or one of its ancestors in our dependencies.

If we found package a/b/c, no errors if in dependencies we've got 'a' or 'a/b' or 'a/b/c'

@ljharb what do you think about ?

[ljharb]

preact/hooks doesn't start with @ or contain node_modules, so yes, that should come from the preact package.

[paztis]

I've created the PR #2097 for this. Can you look at it ?