fixes #348

import-js · Jun 21, 2016 · 66c84ea · 66c84ea
1 parent 1e05a0f
commit 66c84ea
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 3 deletions.
diff --git a/src/core/getExports.js b/src/core/getExports.js
@@ -334,8 +334,11 @@ export default class ExportMap {
     this.namespace.forEach((v, n) =>
       callback.call(thisArg, v, n, this))
 
-    this.reexports.forEach(({ getImport, local }, name) =>
-      callback.call(thisArg, getImport().get(local), name, this))
+    this.reexports.forEach(({ getImport, local }, name) => {
+      const reexported = getImport()
+      // can't look up meta for ignored re-exports (#348)
+      callback.call(thisArg, reexported && reexported.get(local), name, this)
+    })
 
     this.dependencies.forEach(dep => dep().forEach((v, n) =>
       n !== 'default' && callback.call(thisArg, v, n, this)))

diff --git a/tests/src/rules/export.js b/tests/src/rules/export.js
@@ -1,4 +1,4 @@
-import { test } from '../utils'
+import { test, SYNTAX_CASES } from '../utils'
 
 import { RuleTester } from 'eslint'
 
@@ -24,6 +24,8 @@ ruleTester.run('export', rule, {
 
     // #328: "export * from" does not export a default
     test({ code: 'export default foo; export * from "./bar"' }),
+
+    ...SYNTAX_CASES,
   ],
 
   invalid: [

diff --git a/tests/src/utils.js b/tests/src/utils.js
@@ -68,4 +68,10 @@ export const SYNTAX_CASES = [
     code: 'import { foo } from "./issue-370-commonjs-namespace/bar"',
     settings: { 'import/ignore': ['foo'] },
   }),
+
+  // issue #348: deep commonjs re-export
+  test({
+    code: 'export * from "./issue-370-commonjs-namespace/bar"',
+    settings: { 'import/ignore': ['foo'] },
+  }),
  ]