Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: backend panics when trying to decode ES256K signed credentials #302

Closed
1 task
nanderstabel opened this issue Jul 31, 2024 · 0 comments · Fixed by #303
Closed
1 task

fix: backend panics when trying to decode ES256K signed credentials #302

nanderstabel opened this issue Jul 31, 2024 · 0 comments · Fixed by #303
Assignees
@nanderstabel
Labels
Backend This issue pertains to the UniMe backend. Bug Something isn't working

Comments

@nanderstabel
Copy link
Contributor

Description

As title.

The panic occurs in get_unverified_jwt_claims because under the hood it uses the jsonwebtoken library to decode messages. However, jsonwebtoken does not support ES256K.

Motivation

UniCore should not panic

Resources

Keats/jsonwebtoken#391

To-do List

  • Handle the error properly
@nanderstabel nanderstabel added Bug Something isn't working Backend This issue pertains to the UniMe backend. labels Jul 31, 2024
@nanderstabel nanderstabel self-assigned this Jul 31, 2024
@nanderstabel nanderstabel moved this from Backlog to In Progress in Impierce SSI Stack Jul 31, 2024
@nanderstabel nanderstabel linked a pull request Jul 31, 2024 that will close this issue
fix: replace jsonwebtoken::decode with base64 decoding #303
Merged
6 tasks
@nanderstabel nanderstabel mentioned this issue Jul 31, 2024
Merged
6 tasks
@github-project-automation github-project-automation bot moved this from In Progress to Done in Impierce SSI Stack Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanderstabel nanderstabel

Labels
Backend This issue pertains to the UniMe backend. Bug Something isn't working
Projects
Impierce SSI Stack
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: replace jsonwebtoken::decode with base64 decoding impierce/identity-wallet
1 participant
@nanderstabel