Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable default-features in identity_iota dependency #28

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented Aug 8, 2024

Description of change

Updating identity_iota from 1.2 to 1.3 introduced an unwanted implicit dependency on openssl which causes problems downstream. This PR fixes that by disabling some of its default features.

Links to any relevant issues

How the change has been tested

Tested by building UniMe through this PR: impierce/identity-wallet#327 (which depends on the change in this PR)

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel reopened this Aug 8, 2024
@nanderstabel nanderstabel self-assigned this Aug 8, 2024
@nanderstabel nanderstabel changed the title fix: disable default-features in identity_iota dependency chore: disable default-features in identity_iota dependency Aug 8, 2024
@nanderstabel nanderstabel added the Chore Tedious, typically non-functional change label Aug 8, 2024
@nanderstabel nanderstabel marked this pull request as ready for review August 8, 2024 13:19
@nanderstabel nanderstabel merged commit 2b88f55 into dev Aug 8, 2024
2 checks passed
@nanderstabel nanderstabel deleted the fix/remove-openssl branch August 8, 2024 13:20
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Chore Tedious, typically non-functional change released on @beta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants