Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove dependency on oid4vc-core #13

Merged
merged 3 commits into from
May 7, 2024
Merged

Conversation

daniel-mader
Copy link
Contributor

@daniel-mader daniel-mader commented May 7, 2024

Description of change

Remove dependency on oid4vc-core crate. The traits oid4vc_core::{Sign, Subject, Verify} should be implemented in the application instead.

Links to any relevant issues

How the change has been tested

n/a

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@daniel-mader daniel-mader added Dependencies Issues related to an update of a dependency file Removed Feature removal that requires a major release. labels May 7, 2024
@daniel-mader daniel-mader requested a review from nanderstabel May 7, 2024 15:35
@daniel-mader daniel-mader self-assigned this May 7, 2024
@daniel-mader daniel-mader marked this pull request as ready for review May 7, 2024 15:40
@daniel-mader daniel-mader changed the title feat: remove oid4vc-core feat: remove dependency on oid4vc-core May 7, 2024
Copy link
Contributor

@nanderstabel nanderstabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, you can now also remove these commented-out dependencies in producer/Cargo.toml :) :

# anyhow = "1.0"
# async-trait = "0.1"
# base64 = "0.22"
# futures = "0.3"
identity_iota.workspace = true
identity_stronghold.workspace = true
iota-sdk.workspace = true
iota_stronghold = { version = "2.0" }
log = "0.4"
serde = "1.0"
# serde_json.workspace = true
# signature.workspace = true
url = "2.5"

@nanderstabel nanderstabel self-requested a review May 7, 2024 19:25
@daniel-mader daniel-mader linked an issue May 7, 2024 that may be closed by this pull request
2 tasks
@daniel-mader daniel-mader merged commit c70c0f1 into dev May 7, 2024
1 check passed
@daniel-mader daniel-mader deleted the feat/remove-oid4vc branch May 7, 2024 19:39
Copy link

🎉 This issue has been resolved in version 1.0.0-beta.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Issues related to an update of a dependency file released on @beta Removed Feature removal that requires a major release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate oid4vc_core.rs
2 participants