Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine how to use Gamepad events, if at all. #551

Closed
toji opened this issue Mar 1, 2019 · 1 comment
Closed

Determine how to use Gamepad events, if at all. #551

toji opened this issue Mar 1, 2019 · 1 comment
Assignees
Milestone

Comments

@toji
Copy link
Member

toji commented Mar 1, 2019

The Gamepad API currently has a proposal for events that would fire on button press/release, which overlaps a bit with our currently proposed use of selectstart/end events. To be clear, the select events fire for inputs other than gamepads and as a result we won't be discarding them. Given that context it's a nice behavioral unification to have them fire for every gamepad button. Also, the select events contain an XRFrame, which is necessary for tracking any timing-sensitive data like device pose. Finally, the state of the gamepad proposal is unclear, with the PR having been opened way back in 2015(!) but being updated as recently as last October.

Still, the fact that these two pairs of events otherwise cover similar functionality means we should do a bit of due-diligence investigation to see if there's any opportunity to merge them.

@NellWaliczek NellWaliczek added this to the CR for 1.0 milestone Mar 4, 2019
@toji toji changed the title Determine if how to use Gamepad events, if at all. Determine how to use Gamepad events, if at all. Mar 15, 2019
@toji toji added the editor triage Issues marked for triage/re-examination by the editors label Apr 1, 2019
@cwilso cwilso modified the milestones: CR for 1.0, May 2019 Apr 29, 2019
@cwilso cwilso removed the editor triage Issues marked for triage/re-examination by the editors label May 1, 2019
@toji
Copy link
Member Author

toji commented May 18, 2019

After further evaluation it does not seem like attempting to align with gamepad events would be beneficial at this point, nor is it clear that they will be stabilized within the time frame that we are considering. As a result, it seems the answer to the question in this issue's title is "Don't."

To be clear, if gamepad events become a well-supported, popular feature in the future we could easily support them alongside our select events without trouble, though the events themselves would fire from window, which isn't terribly useful for XRSession-scoped input, wouldn't have an indication of what XRInputSource they were related to, and would not contain the XRFrame necessary to evaluate any sort of spatial relationships.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants