fix: Use .esm.js module for backwards compatibility with old build tools #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for quizzical-lovelace-dcbd6a canceled.
|
Pull Request Test Coverage Report for Build 2312748447Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
Thanks @cdauth Fwiw, the same PR you did with a breaking change flag would have been just fine. What's the process to have this merged and released ? |
|
Merging this PR blindly to hopefully fix the issue! (I'm so tired of ESM) |
|
🎉 This PR is included in version 9.0.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
I can confirm it fixed it for react-native. |
1 task
|
Yes, things are back to normal. Thank you @cdauth and @mweststrate for the quick fix |
|
Thank you @cdauth @mweststrate and @f-roland |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some people have reported trouble with the new release of immer, in particular in #937 and #921. The reason seems to be that older build tools are having trouble to understand
.mjsfiles as JavaScript.Since currently immer publishes both an
.esm.jsand.esm.mjsbundle (introduced in #921), with the whole purpose of being backwards compatible, in this pull request I'm reverting themoduleand other fields inpackage.jsonto using the.esm.jsbundle, while only theexportsfield uses the.esm.mjsbundle. I'm hoping that this will achieve both compatibility with Node.js as well as ancient build tools.