Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Add failing test for nested and chained produce calls #935

Merged
merged 2 commits into from
Jan 15, 2023

Conversation

jpallen
Copy link
Contributor

@jpallen jpallen commented May 10, 2022

No description provided.

@netlify
Copy link

netlify bot commented May 10, 2022

Deploy Preview for quizzical-lovelace-dcbd6a canceled.

Name Link
🔨 Latest commit 4f77f40
🔍 Latest deploy log https://app.netlify.com/sites/quizzical-lovelace-dcbd6a/deploys/627ac4ff8cdc4100095cf518

@mweststrate mweststrate changed the title Add failing test for nested and chained produce calls [on hold] Add failing test for nested and chained produce calls Jan 15, 2023
@mweststrate
Copy link
Collaborator

Putting on hold for now, as the test looks legit but contrived, so some context on the original problem this is addressing would be needed to be able to figure this one out.

@mweststrate
Copy link
Collaborator

Ah, this might relate to #917, will check on top of that

@mweststrate mweststrate changed the title [on hold] Add failing test for nested and chained produce calls [minor] Add failing test for nested and chained produce calls Jan 15, 2023
@jpallen
Copy link
Contributor Author

jpallen commented Jan 15, 2023

Thanks for looking at this. This test is capturing the bug I described in #936, which has a bit more context as to what conditions triggered this error.

@mweststrate mweststrate merged commit 04c5fb3 into immerjs:main Jan 15, 2023
@mweststrate
Copy link
Collaborator

NOTE: will merge this diff, which will break main, but otherwise I have to cherrypick the test and the original attribution to @jpallen would be lost :)

mweststrate added a commit that referenced this pull request Jan 15, 2023
@github-actions
Copy link
Contributor

🎉 This PR is included in version 9.0.19 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants