Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch NoFlo runner to noflo-nodejs #56

Closed
bergie opened this issue Feb 2, 2016 · 5 comments
Closed

Switch NoFlo runner to noflo-nodejs #56

bergie opened this issue Feb 2, 2016 · 5 comments

Comments

@bergie
Copy link
Member

bergie commented Feb 2, 2016

Currently imgflo-server is executing NoFlo graphs via the noflo command, which will be removed in 0.6: noflo/noflo#297

https://github.com/jonnor/imgflo-server/blob/970f519a19c6f5fded08154045a9a0cd4d8c197b/src/noflo.coffee#L39

Should use noflo-nodejs instead. This also has the additional benefit of adding component loader cache support needed for #55

@jonnor
Copy link
Member

jonnor commented Feb 2, 2016

Branch noflo-cache, should have everything needed on imgflo-server side.
Fixed some things in noflo-nodejs, released as 0.6.1. But it needs some --port=auto feature also for concurrency to work.

But even with a single request, the network never stops. Tested with TESTS=1977 make check.

By my reckoning these component all have broken behavior. But I don't know right fixes, either network ended prematurely or never stopped. CC/ @bergie

  • canvas/CreateCanvas and canvas/CreateCanvas-node - missing disconnect() ?
  • canvas/Draw- missing connect handling/forwarding?
  • noflo-helper-arrayable (basecomponent for bunch of canvas components) - missing disconnect() ?
  • * image/CreateImage and image/CreateImage-node - possibly missing connect/disconnect unless AsyncComponent takes care of it

@jonnor
Copy link
Member

jonnor commented Feb 18, 2016

Probably best way forward is to make some tests in noflo-image, with simple graphs ran with noflo-nodejs. For instance one which just loads file and saves it again, then one that does some simple processing. And just verify that the process exits as expected.

@jonnor jonnor closed this as completed in a459aee Mar 29, 2016
@jonnor jonnor reopened this Mar 29, 2016
@jonnor
Copy link
Member

jonnor commented Mar 29, 2016

Not fixed, just wanted to reference the issue in the commit.

@bergie
Copy link
Member Author

bergie commented Mar 30, 2016

Likely related to noflo/noflo#221

@jonnor
Copy link
Member

jonnor commented Apr 25, 2018

Existing solution is OK

@jonnor jonnor closed this as completed Apr 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants