Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Performance regression Nov 12 #107

Open
jonnor opened this issue Nov 16, 2016 · 5 comments
Open

Performance regression Nov 12 #107

jonnor opened this issue Nov 16, 2016 · 5 comments

Comments

@jonnor
Copy link
Member

jonnor commented Nov 16, 2016

imgflo-gegl-0 3 10-slower

Likely this is from when we updated to BABL 0.1.20 (from 0.1.18) / GEGL 0.3.10 (from 0.3.6).

@jonnor
Copy link
Member Author

jonnor commented Nov 16, 2016

The distribution of processing time has changed. It has stretched out considerably, which explains percentiles increasing and average shifting upwards. It is also become bimodal instead of the nicely uniform distribution of before.
imgflo-gegl-0 3 10-processingtimes

@jonnor
Copy link
Member Author

jonnor commented Nov 16, 2016

Average processing time went from 2.97 seconds to 4.5 seconds, a +50% increase.

@jonnor
Copy link
Member Author

jonnor commented Nov 16, 2016

More worrysome is that 90% percentile is up to 8 seconds from 4.5 seconds. This significantly impacts our ability to guarantee timely delivery in all cases.

@jonnor
Copy link
Member Author

jonnor commented Nov 16, 2016

Images which were downscaled a lot were over twice as slow, images which was not downscaled a lot were ctually a little bit faster.
imgflo-gegl-0 3 10-outputsizediffs

@jonnor
Copy link
Member Author

jonnor commented Nov 16, 2016

Also for big images which were not downscaled so much shows much smaller change. This supports @hodefoting theory that this is mostly about the improved downscaling, which now takes more input pixels into account.
imgflo-gegl-0 3 10-biginputs-lowdownscale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant