Skip to content

Commit

Permalink
Remove now-obsolete layout regression tests (from issue #67) obsolete…
Browse files Browse the repository at this point in the history
…d by the fix for issue #12.
  • Loading branch information
JaredReisinger committed Dec 11, 2013
1 parent 8b82a84 commit 6314843
Showing 1 changed file with 3 additions and 34 deletions.
37 changes: 3 additions & 34 deletions Samples/PluginTestingApp/Misc/DiagnoticJson.htm
Original file line number Diff line number Diff line change
Expand Up @@ -233,54 +233,23 @@ <h1>Diagnostic JSON</h1>
}

function autoCropAndScalingTests() {
// TODO: remove when fix is verified
checkJsonResult('autocrop scale down BAD (current)',
'diagnostic-300x400.png?width=400&height=300&mode=crop&scale=down', {
finalRect: { width: 400, height: 300 },
imageSourcePoly: { x: 0, y: 88, width: 300, height: 225, rect: true },
imageDestPoly: { x: 0, y: 0, width: 400, height: 300, rect: true },
imageDestAreaPoly: { x: 0, y: 0, width: 400, height: 300, rect: true }
});

// TODO: verify the desired source/dest-poly values
checkJsonResult('autocrop scale down GOOD (desired)',
checkJsonResult('autocrop scale down',
'diagnostic-300x400.png?width=400&height=300&mode=crop&scale=down', {
finalRect: { width: 300, height: 300 },
imageSourcePoly: { x: 0, y: 50, width: 300, height: 300, rect: true },
imageDestPoly: { x: 0, y: 0, width: 300, height: 300, rect: true },
imageDestAreaPoly: { x: 0, y: 0, width: 300, height: 300, rect: true }
});

// TODO: remove when fix is verified
checkJsonResult('autocrop scale canvas BAD (current)',
'diagnostic-300x400.png?width=400&height=300&mode=crop&scale=canvas', {
finalRect: { width: 400, height: 300 },
imageSourcePoly: { x: 0, y: 88, width: 300, height: 225, rect: true },
imageDestPoly: { x: 0, y: 0, width: 400, height: 300, rect: true },
imageDestAreaPoly: { x: 0, y: 0, width: 400, height: 300, rect: true }
});

// TODO: verify the desired source/dest-poly values
checkJsonResult('autocrop scale canvas GOOD (desired)',
checkJsonResult('autocrop scale canvas',
'diagnostic-300x400.png?width=400&height=300&mode=crop&scale=canvas', {
finalRect: { width: 400, height: 300 },
imageSourcePoly: { x: 0, y: 50, width: 300, height: 300, rect: true },
imageDestPoly: { x: 50, y: 0, width: 300, height: 300, rect: true },
imageDestAreaPoly: { x: 0, y: 0, width: 400, height: 300, rect: true }
});

// REVIEW: Is the current behavior actually already correct?
// TODO: remove when fix is verified
checkJsonResult('autocrop scale both BAD (current)',
'diagnostic-300x400.png?width=400&height=300&mode=crop&scale=both', {
finalRect: { width: 400, height: 300 },
imageSourcePoly: { x: 0, y: 88, width: 300, height: 225, rect: true },
imageDestPoly: { x: 0, y: 0, width: 400, height: 300, rect: true },
imageDestAreaPoly: { x: 0, y: 0, width: 400, height: 300, rect: true }
});

// TODO: verify the desired source/dest-poly values
checkJsonResult('autocrop scale both GOOD (desired)',
checkJsonResult('autocrop scale both',
'diagnostic-300x400.png?width=400&height=300&mode=crop&scale=both', {
finalRect: { width: 400, height: 300 },
imageSourcePoly: { x: 0, y: 88, width: 300, height: 225, rect: true },
Expand Down

0 comments on commit 6314843

Please sign in to comment.