-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rough draft including ravif for AVIF encoding #1314
Conversation
Probably should move these into a more central place where dispatch logic lives, or into the upcoming color convert. Only the final step, converting a byte slice to rgb::RGBA, is somewhat special.
I have no idea how to test the encoding without depending on the availability of |
For testing:
|
@kornelski The pixel decoding would be more interesting, of course then also with full bindings, and the pure structure seems like a duplicated effort. I suppose we just wait here, any updates on the situation are appreciated. |
There is a partial rewrite of dav1d in https://github.com/rainliu/rav1d/ but it yielded an error no matter which image I gave it. |
Converts the data to the
Img
buffer and encodes it into an intermediate vector, then writes this into the output writer. It tries to avoid actually allocating for that conversion. It considers thatRGBA8
can be converted from any byte slice and uses the applicable conversion. Any non-rgba8 image is converted using an intermediate buffer. (cc: @fintelia) Some of this code may be used for the conversion feature as well.However it does not support limits.
Closes: #1152