Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump MSRV to 1.46 and release version 0.17.0 #300

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

fintelia
Copy link
Contributor

Our bitflags dependency decided to bump their minimum supported Rust version, so we must do the same.

Fixes #272 (which is long, long overdue)

@fintelia fintelia requested a review from HeroicKatora August 14, 2021 01:52
Copy link
Member

@HeroicKatora HeroicKatora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed that it's overdue and that the plan detailed in #213 was too extensive. Let's do the rest of those changes (in particular custom chunks) in the next version then.

Cargo.toml Show resolved Hide resolved
@fintelia fintelia merged commit d60d487 into image-rs:master Aug 14, 2021
@HeroicKatora
Copy link
Member

HeroicKatora commented Aug 19, 2021

Follow up to the MSRV discussion: naga, the Rust multi-gl transpiler, had the same issue with their own MSRV and resolved it by making it incompatible with 1.3: https://github.com/gfx-rs/naga/blob/v0.6/Cargo.toml#L18-L19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Publish version including miniz_oxide update
2 participants