-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1bit greyscale encoder support #24
Comments
Hello, would you be able to share a problematic image with us? There is nothing that specifically forbids 1bit images (https://github.com/image-js/fast-png/blob/master/src/PngDecoder.ts#L475-L486), but it is not tested because we have never encountered such images. |
oh sorry, I wasn't precise enough. I meant 1bit greyscale support for the encoder: Line 100 in bdb81f9
We are using fast-png to create, store and read bitmasks for that images with 1bit depth would be much smaller than greyscale images. I'll see if I can create one with another encoder. |
I see. Feel free to try and implement it here if you want! |
Any plans on supporting bit depths other than 8 and 16? I would have use for a 1bit greyscale implementation. Also not averse to contributing but would like some hints why other depths weren't implemented before I spent time and dig in to avoid double work.
Great library btw. I'm really impressed with the speed, it even beat the ImageDecoder from the browser built-in WebCodecs for small greyscale pngs.
The text was updated successfully, but these errors were encountered: