Add rotate angle to chart #124
Conversation
remove extra methods
move this param to line chart sample 5
|
Hey there, fix your notes. I added |
add alignment for text side titles
add alignment for text side titles
|
Add |
|
Hey there, good catch about the bug, please think about it and introduce a way to handle all kinds of these states for all top, right, bottom, left sides. |
|
Good point, didn't think about that at all. Will fix these states. |
|
Fix rotating and translate of center
|
|
Looks great man :) |
|
Thanks |
|
Everything looks great, |
|
Your welcome & thanks to you for cooperating & I'm glad it works. |
|
Did you read my review comment? |
change snapshot of bar chart sample 5
|
All set |
| @@ -111,6 +111,13 @@ class FlTitlesData { | |||
| } | |||
| } | |||
|
|
|||
| /// this is mimic of [MainAxisAlignment] to aligning the [SideTitles] | |||
| enum SideTitlesAlignment { | |||
There was a problem hiding this comment.
I think we don't need SideTitlesAlignment anymore?
Can you explain it's usage?
There was a problem hiding this comment.
The default position of TextPainter is center of it's x-axis point.
I just add this alignment for whom wanna set this view for better rendering in special cases.
If you think it's an irrelevant parameter I can remove it.
There was a problem hiding this comment.
Please let's remove it because it is not fully customizable, we can just customize the x-axis pivot, and for sure we should add customization for both axes.
We can add it in the future if it is needed.
Thanks!
There was a problem hiding this comment.
that's a good point, I just removed it.
|
Great, thank you for being patient and resolve all discussions. |
|
Oh man, this should be white backgrounded (currently it is gray). |
|
Forget about it, I've just fixed it, see in the commit. |
|
Much an apprentice buddy. So glad to work with you |
|
Hope to see your more PRs :) |
add
rotateAngleparameter toSideTitles.consider to this issue I just add this feature to the chart.