Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2121 - Add hindi localization support for a few patterns #2128

Closed

Conversation

rishu1601
Copy link

Added the hindi localization for:

  • adpater
  • factory
  • observer
  • prototype
  • singleton
  • strategy

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@rishu1601
Copy link
Author

Hey @iluwatar , waiting for your review

@rishu1601
Copy link
Author

Hi @iluwatar , please review this PR

@rishu1601
Copy link
Author

Hi @iluwatar

@iluwatar
Copy link
Owner

iluwatar commented Nov 5, 2022

Part of issue #2279

Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, there is a conflict preventing the merge. Please resolve it.

Comment on lines +1 to +10
---
layout: pattern
title: Adapter
folder: adapter
permalink: /patterns/adapter/hi
categories: Structural
language: hi
tags:
- Gang of Four
---
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at the updated yaml frontmatter requirements at https://github.com/iluwatar/java-design-patterns/wiki/01.-How-to-contribute. You can drop some of the tags. Check this for all the patterns in this PR.

@stale
Copy link

stale bot commented Dec 5, 2022

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Dec 5, 2022
@stale
Copy link

stale bot commented Jan 19, 2023

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants