Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Battery discharge model: wrong xml tag #145

Open
alierum opened this issue Nov 2, 2020 · 1 comment
Open

Battery discharge model: wrong xml tag #145

alierum opened this issue Nov 2, 2020 · 1 comment

Comments

@alierum
Copy link

alierum commented Nov 2, 2020

In the robot's text definition, i.e. eyebot_entity.cpp the battery uses the attribute "model"

<battery model=\"time_motion\" time_factor=\"1e-5\"\n"
                                  pos_factor=\"1e-3\"\n"
                                  orient_factor=\"1e-3\"/>\n

However, in battery_equipped_entity.cpp the attibute name is "discharge_model"

GetNodeAttributeOrDefault(t_tree, "discharge_model", strDischargeModel, strDischargeModel);

Which is the correct attribute ("model" doesn't work), so the help texts in all the *_entitiy.cpp files should be updated.

@jharwell
Copy link
Collaborator

jharwell commented Apr 1, 2021

The code says discharge_model, so that's probably what it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants