Close #28 Khurshid/organization controller #54
Conversation
| private readonly AppDbContext _ctx; | ||
| private readonly UserManager<AppUser> _userm; | ||
|
|
||
| public OrganizationController(AppDbContext context, UserManager<AppUser> usermanager,ILogger<OrganizationController> logger) |
| } | ||
|
|
||
| [HttpGet] | ||
| public async Task<IActionResult> Created() |
There was a problem hiding this comment.
OrganizationListViewModel
- List Organizations
- int page
- int limit
- int totalPages
- int total
| { | ||
|
|
||
| [Authorize] | ||
| public class OrganizationController : Controller |
|
|
||
|
|
| } | ||
|
|
||
| [HttpPost] | ||
| public async Task<IActionResult> UpdateModel(Guid id, OrganizationModel model) |
There was a problem hiding this comment.
UpdateOrganizationViewModel.cs
| return RedirectToAction("Created"); | ||
| } | ||
|
|
||
| var returnedModel = _ctx.Organizations.FirstOrDefault(o => o.Id == id); |
|
|
||
|
|
||
| [HttpGet] | ||
| public IActionResult GetById(OrganizationViewModel org) |
There was a problem hiding this comment.
Guid id,
OrganizationViewModel qaytaradi. idga ega Organization
webapp/Entity/Contact.cs
Outdated
|
|
||
|
|
| public virtual ICollection<Invoice> Invoices { get; set; } | ||
|
|
There was a problem hiding this comment.
Invoices qolsinmi?
| @@ -1,5 +1,6 @@ | |||
| using webapp.Entity; | |||
| using webapp.ViewModel; | |||
| using webapp.ViewModels; | |||
|
|
|||
| namespace webapp.Extensions; | |||
| public static class ToViewModels | |||
There was a problem hiding this comment.
ContactEntityExtensions.cs
@KhurshidUmid siz OrganizationExtensions.cs class ga hamma kodizni ko'chirasiz.
There was a problem hiding this comment.
Bu kecha bajarilgan
|
@wahid-d OrganizationController To'g'riladim, tekshirib bering |
| var user = await _userm.GetUserAsync(User); | ||
| if(user == null) | ||
| { | ||
| return Unauthorized(); | ||
| } |
There was a problem hiding this comment.
Bu actionda user ishlatilmagani uchun bu shart emas. Unauthorizedni esa tepadagi attribute o'zi qaytaradi shundoq ham
| return Unauthorized(); | ||
| } | ||
|
|
||
| var createdOrgs = await _ctx.Organizations |
| if (createdOrgs == null) | ||
| { | ||
| return NotFound(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Yoq, prosta bironta ham Oranizationsiz qaytarilaveradi. NotFound faqat izlangan ma'lumot topilmaganda qaytariladi.
| Organizations = createdOrgs, | ||
| totalOrganizationsCount = totalOrganizations, | ||
| totalPages = (int)Math.Ceiling(totalOrganizations / (double)limit), | ||
| Page = page, | ||
| Limit = limit |
There was a problem hiding this comment.
Just PaginatedListViewModel.cs from ViewModels folder.
- Just supply the Items type for generic class. For this action, it's OrganizationViewModel
There was a problem hiding this comment.
|
|
||
|
|
||
|
|
||
|
|
| [HttpGet] | ||
| public IActionResult New() => View(new CreateOrganizationViewModel()); |
There was a problem hiding this comment.
This action should go upto right before Create action.
| return NotFound(); | ||
| } | ||
|
|
||
| return View(org.ToOrgModel()); |
| if (org == default) | ||
| { | ||
| return NotFound(); | ||
| } |
There was a problem hiding this comment.
You dont need this since you already have AnyAsync above.
| } | ||
| catch (Exception e) | ||
| { | ||
| _logger.LogWarning($"Error occured while updating organization:\n{e.Message}"); |
| } | ||
| catch (Exception e) | ||
| { | ||
| _logger.LogWarning($"Error occured while updating organization:\n{e.Message}"); |
| Address = u.Address, | ||
| }).ToListAsync(); | ||
|
|
||
| var totalOrganizations = existingOrgs.Count(); |
There was a problem hiding this comment.
Bu xato. Paginationni ishdan chiqaradi.
var totalOrganizations = await _ctx.Organizations.CountAsync();| { | ||
| _logger.LogInformation($"Model validation failed for {JsonSerializer.Serialize(model)}"); | ||
| // return BadRequest("Organization properties are not valid."); | ||
| return View(); |
| var org = new Organization() | ||
| { | ||
| Id = Guid.NewGuid(), | ||
| Name = model.Name, | ||
| Address = model.Address, | ||
| Phone = model.Phone, | ||
| Email = model.Email, | ||
| OwnerId = user.Id | ||
| }; |
There was a problem hiding this comment.
Organization(model.Name, model.Address, model.Phone, model.Email, user.Id);
Organization entity ichida default constructorni obsolete qilib qo'yish kerak.
| await _ctx.Organizations.AddAsync(org); | ||
| await _ctx.SaveChangesAsync(); | ||
| _logger.LogInformation($"New organization added with ID: {org.Id}"); | ||
| _logger.LogInformation($"New EmployeeOrganization added with ID: {user.Id}"); |
| _logger.LogInformation($"New organization added with ID: {org.Id}"); | ||
| _logger.LogInformation($"New EmployeeOrganization added with ID: {user.Id}"); | ||
|
|
||
| return RedirectToAction(nameof(Created)); |
There was a problem hiding this comment.
Created degan Action yoqku bizda?
There was a problem hiding this comment.
show ga qilib quydim
|
sizda bazi actionlar nomi notogri. Masalan: Tugatgandan keyin kod ni test qilish kerak. Ishlaydimi yoqmi?oddiy viewlar yaratib olib uiga etibor bermay bir test qilib controller ishlaydimi yoqmi? |
OrganizationController finished and ready to review
Closes #28