Fix no_std support if serde is depended on #19
Conversation
The proc-macro-crate depends on toml, which in turn depends on serde _with_ std. Only depend on proc-macro-crate if std is enabled. This means that no_std consumer of num_enum cannot rename their num_enum dependency. This seems like a reasonable restriction. Works around rust-lang/cargo#5730
|
This is technically a semver breaking change, as it would break anyone who is no_std and has renamed their num_enum dependency, but I'm not quite sure that niche justifies bumping to 0.5... Would appreciate thoughts! |
There was a problem hiding this comment.
Good job! 👌
Breaking change?
After thinking about it, I have a preference for this being version 0.5.0, i.e., a breaking change semver-wise. Indeed:
-
although extremely unlikley, it is not impossible that some
no_stddependency did renamenum_enum, as you mentioned; -
this change is a "fix" for proc-macro-crate is not no_std #18, for which users suffering from it "only" have to bump / update the dependency version. Future users will use the last version anyways.
In other words, I see this as "it is better to risk saving a guilty [person] than to condemn an innocent one": it is better to risk requiring some people to manually bump the version than to make some "innocent" configuration start failing 😄
The proc-macro-crate depends on toml, which in turn depends on serde
with std. Only depend on proc-macro-crate if std is enabled.
This means that no_std consumer of num_enum cannot rename their num_enum
dependency. This seems like a reasonable restriction.
Works around rust-lang/cargo#5730
Fixes #18