You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently if you use cargo --test --all workspace crates are compiled with their default features (--features does not affect them) and link against the root package that is built with the specified features including dev-dependencies. If you use cargo test --manifest-path ... to manually run test for a workspace crate that references the root package then the root package is recompiled without dev-dependencies.
Ideally the uom CI build scripts should run both uom and feature_check tests and only compile uom once.
A possible short term fix is to have feature_check use the same feature set in the cargo build invocation so those build artifacts can be reused.
The text was updated successfully, but these errors were encountered:
Currently cargo test --all --features ... still does not pass features to all workspace crates. Oddly workspace crates still use the version compiled with features. Currently feature_check is reusing the previously compiled uom but edition_check isn't because --manifest-path needs to be used as the crate is not part of the workspace. Once the minimum required rustc is bumped to 1.31.0 (Rust 2018 edition) then edition_check can be added back into the workspace and this issue should be reviewed again.
See https://internals.rust-lang.org/t/help-us-test-the-breaking-bug-fix-to-cargo-features/7317 and rust-lang/cargo#5364. Also see the current
.travis.yml
wherecargo test
is run once foruom
and once forfeature_check
.Currently if you use
cargo --test --all
workspace crates are compiled with their default features (--features
does not affect them) and link against the root package that is built with the specified features includingdev-dependencies
. If you usecargo test --manifest-path ...
to manually run test for a workspace crate that references the root package then the root package is recompiled withoutdev-dependencies
.Ideally the
uom
CI build scripts should run bothuom
andfeature_check
tests and only compileuom
once.A possible short term fix is to have
feature_check
use the same feature set in thecargo build
invocation so those build artifacts can be reused.The text was updated successfully, but these errors were encountered: