Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Out Store Offerings #44

Open
1 of 5 tasks
ilan-gold opened this issue Nov 18, 2024 · 5 comments
Open
1 of 5 tasks

Build Out Store Offerings #44

ilan-gold opened this issue Nov 18, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@ilan-gold
Copy link
Owner

ilan-gold commented Nov 18, 2024

We currently only do file system store: https://github.com/ilan-gold/zarrs-python/blob/main/src/codec_pipeline_store_filesystem.rs but should expand to, at the minimum, HTTP.

@kylebarron
Copy link

kylebarron commented Jan 9, 2025

👋 Long time no see!

I've been working on a library that may be helpful here: pyo3-object_store. It's designed to define builders once, so that many Python-Rust bindings can reuse the same ObjectStore integration.

It enables your functions that use object store to be as simple as:

#[pyfunction]
pub fn use_object_store(store: PyObjectStore) {
    let store: Arc<dyn ObjectStore> = store.into_inner();
}

I've been meaning to update and publish a new release of pyo3-object_store. It would be cool to prototype an integration here.

@ilan-gold
Copy link
Owner Author

Hi @kylebarron funny how that happens.

I think (@LDeakin can correct me) that one would need to implement the necessary traits on the object_store object from https://docs.rs/zarrs_storage/0.3.0/zarrs_storage/index.html to get a compatible store for zarrs (to work with https://github.com/ilan-gold/zarrs-python/blob/main/src/store/manager.rs#L17).

But where that happens and how is probably more a matter of discussion. That would be very cool though!

@kylebarron
Copy link

@ilan-gold
Copy link
Owner Author

Ah ok, @LDeakin is very comprehensive!

@LDeakin
Copy link
Collaborator

LDeakin commented Jan 9, 2025

Cool stuff @kylebarron! Yeah, I'd be interested to see an integration

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants