Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firstattack trigger is true for target if counter hit. #1082

Closed
AshtonTurner opened this issue Mar 21, 2023 · 0 comments · Fixed by #1085
Closed

Firstattack trigger is true for target if counter hit. #1082

AshtonTurner opened this issue Mar 21, 2023 · 0 comments · Fixed by #1085
Labels
bug Something isn't working regression Something that used to work correctly

Comments

@AshtonTurner
Copy link

AshtonTurner commented Mar 21, 2023

Describe the bug

If you hit the opponent while they are in movetype=A, hitdef doesnt have to be active, when you connect and it's the first hit it will give the first attack reward to the target.

To Reproduce

using KFM provided with Ikemen Go:

  1. press x for p1 and y on p2 at the same time on keyboard.
  2. observe that p1 hits p2 before p2's attack comes out.
  3. if done right p1 will hit first but p2 will get the first attack message and firstattack for p2 will be 1

Expected behavior

if p1 hits p2 in any capacity first, firstattack should be 1 for p1.

Screenshots / Video

ikemen000
p1 hits p2 and p2 gets reward after p1 presses x and p2 presses y

ikemen001
another example

Engine Version (or source code date)

v0.99.0RC1

Operating system

Windows

Extra context or search terms

firstattack, counter hit

@K4thos K4thos added bug Something isn't working regression Something that used to work correctly labels Mar 22, 2023
@K4thos K4thos closed this as completed Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Something that used to work correctly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants