Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destroyself + RedirectID #1014

Closed
potsmugen opened this issue Mar 5, 2023 · 2 comments · Fixed by #1076
Closed

Destroyself + RedirectID #1014

potsmugen opened this issue Mar 5, 2023 · 2 comments · Fixed by #1076
Labels
bug Something isn't working

Comments

@potsmugen
Copy link
Contributor

Describe the bug

These two currently don't work together. The helper that calls it will destroy itself instead of the redirected target.

To Reproduce

  1. Download this debug version of KFM
    kfmdestroyself.zip

  2. Create helpers with P2

  3. KFM's helper will destroy itself instead of the enemy helpers, despite using RedirectID

Expected behavior

Destroyself with RedirectID should destroy the targeted helper, of course. Incidentally, the state controller might need to be adjusted to that the rest of the state is still processed if it uses RedirectID, like what happened with ChangeState and SelfState.

Screenshots / Video

No response

Engine Version (or source code date)

28/02/2023

Operating system

Windows

Extra context or search terms

No response

@K4thos K4thos added the bug Something isn't working label Mar 16, 2023
@K4thos
Copy link
Member

K4thos commented Mar 20, 2023

I couldn't reproduce it. I assume you've experienced this problem because of typo - in your test kfm you've used "reidrectID" instead of "redirectID". I think we should make the compiler more strict to catch such typos.

But there was a different problem here that has been fixed: when destroyself was used it stopped further script execution even if it was redirected to different id

@potsmugen
Copy link
Contributor Author

Silly me. I was going trough my list of things to report, so I'm sure it didn't work at some point, but then made that typo in the test case. Well what matters is that it's working and something good still came out of this report. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants