Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow closing flow seq/map at same indentation #3

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

rliebz
Copy link

@rliebz rliebz commented Mar 27, 2024

The commit as written does not include running tree-sitter generate. Happy to run that if someone can point me to the documentation for how that can be done for the current iteration of the repo.

For reference, here is a working version of the fix from before the repo was forked: rliebz@c1c2506

Resolves: ikatyang#29
Relates-to: #2

@rliebz rliebz force-pushed the close-indent-updated branch from 27ac51f to 5dec996 Compare March 27, 2024 12:15
@rliebz
Copy link
Author

rliebz commented Mar 27, 2024

@clason Rebased with your change from #2, ran tree-sitter generate, and should be good to go!

As an FYI, the test suite on master appears to be broken with 23 failures. This adds two passing tests with no regressions.

@clason
Copy link

clason commented Mar 27, 2024

Yes, I know; this fork is just a band-aid on what was there before. (Note that all failing tests are for invalid syntax; the error is now just somewhere else in the tree.)

@clason clason requested a review from amaanq March 27, 2024 12:38
@amaanq amaanq merged commit c9ee63b into tree-sitter-grammars:master Apr 2, 2024
@amaanq
Copy link
Member

amaanq commented Apr 2, 2024

nice, thanks

@rliebz rliebz deleted the close-indent-updated branch July 19, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Faulty parsing of arrays that look like they might be strings
3 participants