Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid accessing unowned memory #17

Merged
merged 1 commit into from
Jan 1, 2021
Merged

fix: avoid accessing unowned memory #17

merged 1 commit into from
Jan 1, 2021

Conversation

dimbleby
Copy link
Contributor

Fixes #16.

Per comment in that issue, I don't understand the code well enough to be sure that this is the right fix. But it looks plausible, and I thought I'd make it easy for you in case it is.

Copy link
Owner

@ikatyang ikatyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

src/scanner.cc Outdated Show resolved Hide resolved
@ikatyang ikatyang changed the title Avoid accessing unowned memory fix: avoid accessing unowned memory Jan 1, 2021
@ikatyang ikatyang merged commit 45ecb42 into ikatyang:master Jan 1, 2021
@ikatyang
Copy link
Owner

ikatyang commented Jan 1, 2021

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heap-buffer overflow
2 participants