Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Websocket V13 #3

Open
tomaszchacuk opened this issue Apr 26, 2016 · 2 comments
Open

Update to Websocket V13 #3

tomaszchacuk opened this issue Apr 26, 2016 · 2 comments

Comments

@tomaszchacuk
Copy link

Is there a chance of upgrading to websockets V13 and add masking feature ?

@ikaras
Copy link
Owner

ikaras commented Apr 27, 2016

Hi, @tomaszchacuk.
Sorry, but I'm busy on the other commercial project for the next 6 months and can't make upgrading :(
If you familiar with it and you can implement it I'll merge your commit into repository with pleasure.

@comboy
Copy link

comboy commented Jun 7, 2016

I'm not making PR since it's not well tested and I have no idea about backwards compatibility, but
here's a quick fix @tomaszchacuk:

https://gist.github.com/comboy/f6d7084fa3740cda3f3461d2c5c89a88

Just replace ws_encode.lua with this. It sets the mask bit and adds mask consisting of 0 bits (I don't think anything more is really needed for nodemcu client)

Works for me with V13 server, but as mentioned, don't trust it too much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants