Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the placeholder text #32

Closed
jhollway opened this issue Oct 1, 2020 · 3 comments · Fixed by #43
Closed

Change the placeholder text #32

jhollway opened this issue Oct 1, 2020 · 3 comments · Fixed by #43
Assignees
Labels
bug Something isn't working

Comments

@jhollway
Copy link
Collaborator

jhollway commented Oct 1, 2020

When printing just a single chapter with chapter_pdf(), the section titles of all the other chapters are included in addition and some 'placeholder' text is entered under some of these extra section titles. These extra section titles either should not appear or appear only in the table of contents printed at the start of the chapter preview.

@jhollway jhollway added the bug Something isn't working label Oct 1, 2020
@jhollway jhollway assigned BBieri and EstherPeev and unassigned henriquesposito and BBieri Jan 4, 2021
@BBieri
Copy link
Collaborator

BBieri commented Jan 4, 2021

Update 04.01.2021

The issue seems to stem from the bookdown function preview_chapter() Doc Here. The documentation, as well as previous issues, have mentionned it on Github and the response from Yi Hui is that this is done by design.

Check out:

@jhollway
Copy link
Collaborator Author

jhollway commented Jan 4, 2021

I think I actually solved this issue in a previous change. chapter_pdf() should use {rmarkdown} not {bookdown} any longer. If this is true, you can close this issue and create a new issue for the other placeholder issue I mentioned: re Harry Potter ( for @EstherPeev )

@BBieri
Copy link
Collaborator

BBieri commented Jan 4, 2021

@jhollway Thanks for the feedback. In the latest version of iheiddown (I pulled today), chapter_pdf() uses bookdown's function to render one chapter at a time. I'll check out a workaround with {rmarkdown} tomorrow first thing in the morning.

I solved the "Harry Potter issue" today by replacing it by LOTR references. Thus, I'll close this issue for now and will create another one for the issue mentioned above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants