Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: deprecate scale argument of centr_eigen() and centr_eigen_tmax() #1625

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

chore: deprecate scale argument of centr_eigen() and centr_eigen_tmax() #1625

wants to merge 4 commits into from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Dec 10, 2024

Fix #1531

Also added tests as there were none.

@maelle maelle requested a review from szhorvat December 10, 2024 11:50
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Dec 10, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

maelle
maelle commented Dec 10, 2024
View reviewed changes
tests/testthat/_snaps/centralization.md
Condition
Warning:
The `loops` argument of `centr_degree_tmax()` must be explicit as of igraph 2.0.0.
i Default value (`FALSE`) will be dropped in next release, add an explicit value for the loops argument.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually wonder why an explicit value is needed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no reasonable default. The user should be forced to make a decision. The decision can only be made based on an understanding of where the network came from—it can't be deduced by looking at the network structure.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooooh I understand now. I think the current message is slightly misleading: I thought support for TRUE was getting dropped, not support for not choosing. 😅

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But now that I know what it means I am not sure how to rephrase the message.

szhorvat
szhorvat reviewed Dec 11, 2024
View reviewed changes
R/centralization.R Outdated Show resolved Hide resolved
szhorvat
szhorvat reviewed Dec 11, 2024
View reviewed changes
R/centralization.R Outdated Show resolved Hide resolved
szhorvat
szhorvat reviewed Dec 11, 2024
View reviewed changes
R/centralization.R Outdated Show resolved Hide resolved
@szhorvat
Copy link
Member

Other than the comments, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szhorvat szhorvat szhorvat left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate scale argument of centr_eigen() and centr_eigen_tmax()
2 participants
@maelle @szhorvat