-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjacent_vertices()
and incident_edges()
are now correct if the "return.vs.es"
option is FALSE
#1606
Conversation
Current Aviator status
This PR was merged manually (without Aviator). Merging manually can negatively impact the performance of the queue. Consider using Aviator next time.
See the real-time status of this PR on the
Aviator webapp.
Use the Aviator Chrome Extension
to see the status of your PR within GitHub.
|
@krlmlr @Antonov548 It should be checked if this bug affects the auto-generated interfaces, and if yes, fixed there as well. |
Thanks for the issue and the PR, good catch! I checked all instances of |
adjacent_vertices()
and incident_edges()
are now correct if the "return.vs.es"
option is FALSE
Yes, I'm happy to do that. Sorry, I wasn't aware of I thought about adding a test, but did not do that because I could not find any existing tests for In addition, I would suggest a test for |
Thanks! Yes, our tests are a bit sparse, adding the tests you're suggesting to |
2ec45c2
to
da770a0
Compare
Thanks! Please open a new PR for the other changes. |
@luukvdmeer: this breaks an assumption in sfnetworks. I don't have time to propose a PR today. Can you release an update on short notice? Thanks! |
Adding @wlandau for drake and targets. I see two options:
Would the second option work for y'all? If not, no problem, I'll go with the first. Thanks! |
Check results with the igraph release candidate:
|
Anything I can do to help? |
Thanks, Stefan. This depends on the course of action we agree on. |
OK, just let me know. |
fixes #1605
The problem is that in
adjacent_vertices()
, 1 is only added to the vertices ifreturn.vs.es
isTRUE
.