Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace audio-encoder dependency #73

Open
igorski opened this issue Jul 6, 2023 · 0 comments
Open

Replace audio-encoder dependency #73

igorski opened this issue Jul 6, 2023 · 0 comments

Comments

@igorski
Copy link
Owner

igorski commented Jul 6, 2023

Versions above 1.0.2 have an error Uncaught (in promise) ReferenceError: MPEGMode is not defined, which stems from an outdated lamejs dependency.

The Git repository for lamejs is updated, but the NPM module isn't, which is why package.json includes the "lamejs": "github:zhuker/lamejs" dependency. Also see zhuker/lamejs#89

This is less than ideal. If the lamejs-library isn't published, or audio-encoder isn't updated to use a different library, we should find a suitable replacement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant