Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor sdf::readXml #681

Merged
merged 3 commits into from
Sep 1, 2021
Merged

Refactor sdf::readXml #681

merged 3 commits into from
Sep 1, 2021

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Aug 31, 2021

Summary

While working on a new feature for the main branch I got a codecheck error saying sdf::readXml is over 500 lines. This simply refactors two sections of the the function into helper functions.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey azeey requested a review from marcoag August 31, 2021 19:57
@azeey azeey self-assigned this Aug 31, 2021
@azeey azeey requested review from aaronchongth and removed request for marcoag August 31, 2021 19:58
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Aug 31, 2021
Copy link
Collaborator

@aaronchongth aaronchongth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring readXml! I think we were just hitting the limit of allowed lines in a single function too 😆, so this is going to make future parsing work much easier. I have a few trivial comments, but everything looks great!

src/parser.cc Outdated Show resolved Hide resolved
src/parser.cc Outdated Show resolved Hide resolved
src/parser.cc Outdated Show resolved Hide resolved
@azeey azeey merged commit d087d47 into gazebosim:sdf9 Sep 1, 2021
@azeey azeey deleted the refactor_readxml branch September 1, 2021 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants