Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to new codecov configuration #676

Merged
merged 1 commit into from
Aug 26, 2021
Merged

Port to new codecov configuration #676

merged 1 commit into from
Aug 26, 2021

Conversation

azeey
Copy link
Collaborator

@azeey azeey commented Aug 26, 2021

🦟 Bug fix

Summary

Use the codecov config proposed in gazebo-tooling/action-gz-ci#32.
This also uses a new codecov url in the README now that sdformat is in the ignitionrobotics org.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸

Also point use a new codecov url now that sdformat is in the
ignitionrobotics org

Signed-off-by: Addisu Z. Taddese <[email protected]>
@github-actions github-actions bot added Gazebo 1️1️ Dependency of Gazebo classic version 11 🏰 citadel Ignition Citadel labels Aug 26, 2021
@azeey azeey requested a review from j-rivero August 26, 2021 17:12
@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2021

Codecov Report

❗ No coverage uploaded for pull request base (sdf9@33fc40a). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 34bc0d7 differs from pull request most recent head 7870e79. Consider uploading reports for the commit 7870e79 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             sdf9     #676   +/-   ##
=======================================
  Coverage        ?   86.83%           
=======================================
  Files           ?       62           
  Lines           ?     9734           
  Branches        ?        0           
=======================================
  Hits            ?     8453           
  Misses          ?     1281           
  Partials        ?        0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33fc40a...7870e79. Read the comment docs.

@chapulina chapulina merged commit 3a8e069 into sdf9 Aug 26, 2021
@chapulina chapulina deleted the azeey/new_codecov branch August 26, 2021 18:08
@scpeters scpeters mentioned this pull request Sep 9, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel Gazebo 1️1️ Dependency of Gazebo classic version 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants